dlmarion commented on PR #6373: URL: https://github.com/apache/accumulo/pull/6373#issuecomment-4480766448
> > > It seems like it would be simpler and also avoid any unintentional drift to just use the size of the existing messages collection instead of maintaining a separate count. Is there a reason you have avoided doing that so far? > > > > > > The separate count is so that a different color can be used for higher priority messages. > > Yea I think its good to have the separate endpoint and be able to show the counts but I think we should be able to compute the count per `MessagePriority` when serving the endpoint right? > Why compute it N times when you could compute it once? > > Regarding the drift, are you seeing that the counts would not be accurate? > > I think it would probably be fine but since `messages` is a set, if we `addMessage()` or `removeMessage()` with a duplicate message or a message that does not exist its possible for the new counter could be incremented (or not) out of sync with the set. That's a good observation, I think I can handle the duplicates easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
