dlmarion commented on PR #6373: URL: https://github.com/apache/accumulo/pull/6373#issuecomment-4487577545
I moved the message count computation to a single method that is called last in the `finish` method. This should make the counts accurate. > Something else that I just thought of is if there might be a better name instead of "Messages" here. To me that reads almost as human-to-human messaging. Two alternatives I could think of are "Notifications" and "Alerts". I think alerts fits the best since notifications seems like pieces of information that tracks whether a user has seen them or not which is not the case here. I have no issue renaming `Messages` to `Alerts`. I can do that in a follow-on PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
