https://bz.apache.org/bugzilla/show_bug.cgi?id=61269

--- Comment #8 from Emmanuel Bourg <[email protected]> ---
The latest patches aren't that different, here are the ones currently applied
to Ant 1.10.16:

https://salsa.debian.org/java-team/ant/-/blob/master/debian/patches/0009-reproducible-timestamp-task.patch?ref_type=heads
https://salsa.debian.org/java-team/ant/-/blob/master/debian/patches/0010-reproducible-javadoc-task.patch?ref_type=heads
https://salsa.debian.org/java-team/ant/-/blob/master/debian/patches/0011-reproducible-propertyfile-task.patch?ref_type=heads

The <tstamp> task has everything to make it reproducible, the user can set the
timezone himself. The idea behind the patch 0009 was to fix the reproducibility
within within Ant itself, rather than fixing the build files in every project
that uses it. This is primarily a convenience for easing the maintainance of
the Debian packages.

The same applies to patch 0010 for the <javadoc> task, however since we are
phasing out Javadoc packages in Debian, this patch will eventually be removed.

I think the 0011 patch for the <propertyfile> task is worth considering. The
date in the comment is a common reproducibility issue, and there is no real way
to fix it other than post-processing the generated file. Ideally, we would
remove the date completely since it is arguably useless. This patch keeps the
date but honors SOURCE_DATE_EPOCH and uses a fixed timezone (UTC) for the date
format. In my opinion, adding a timezone parameter to the task would be
overkill just to handle a simple comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to