membphis commented on a change in pull request #1248: Making username and
password as required fields for basic auth plugin
URL: https://github.com/apache/incubator-apisix/pull/1248#discussion_r392046738
##########
File path: t/plugin/basic-auth.t
##########
@@ -123,7 +123,10 @@ passed
ngx.HTTP_PUT,
[[{
"plugins": {
- "basic-auth": {}
+ "basic-auth": {
+ "username": "foo",
Review comment:
That is wrong.
When a user requests, the authentication information is placed in an HTTP
header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
