sshniro commented on a change in pull request #1248: Making username and
password as required fields for basic auth plugin
URL: https://github.com/apache/incubator-apisix/pull/1248#discussion_r392052823
##########
File path: t/plugin/basic-auth.t
##########
@@ -123,7 +123,10 @@ passed
ngx.HTTP_PUT,
[[{
"plugins": {
- "basic-auth": {}
+ "basic-auth": {
+ "username": "foo",
Review comment:
Hi @membphis , I'm a bit unclear, this test case is enabling basic auth
plugin using admin api.
The test case 8 does the verification by adding the http header.
```
=== TEST 8: verify
--- request
GET /hello
--- more_headers
Authorization: Basic Zm9vOmJhcg==
--- response_body
hello world
--- no_error_log
[error]
```
I agree, in order to enable basic auth the admin does not have to send the
same info again. Any suggestion how to tackle this would be helpful. I guess
the scenario is the same with key-auth plugin as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
