moonming commented on a change in pull request #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#discussion_r402760554
########## File path: doc/plugins/zipkin-cn.md ########## @@ -49,7 +51,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 "plugins": { "zipkin": { "endpoint": "http://127.0.0.1:9411/api/v2/spans";, - "sample_ratio": 1 + "sample_ratio": 1, + "service_name": "APISIX-IN-SG", + "server_addr": "8.8.8.8" Review comment: Is it the server's address that needs to be filled in here, or is it the DNS address? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
