moonming commented on issue #1386: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1386#issuecomment-608380733 I think like local ip address `192.168.3.50` is ok Thanks, Ming Wen Twitter: _WenMing Lien <[email protected]> 于2020年4月3日周五 下午5:46写道： > *@lilien1010* commented on this pull request. > ------------------------------ > > In doc/plugins/zipkin-cn.md > <https://github.com/apache/incubator-apisix/pull/1386#discussion_r402887480> > : > > > @@ -49,7 +51,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 > "plugins": { > "zipkin": { > "endpoint": "http://127.0.0.1:9411/api/v2/spans";, > - "sample_ratio": 1 > + "sample_ratio": 1, > + "service_name": "APISIX-IN-SG", > + "server_addr": "8.8.8.8" > > how about change it into 1.2.3.4 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-apisix/pull/1386#discussion_r402887480>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGJZBK7T3IGAAERYAXGP66DRKWV7VANCNFSM4LY4XAOQ> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
