membphis commented on a change in pull request #1645:
URL: https://github.com/apache/incubator-apisix/pull/1645#discussion_r434941258
##########
File path: t/plugin/prometheus.t
##########
@@ -534,3 +534,79 @@ GET /apisix/prometheus/metrics
qr/.*apisix_http_overhead_bucket.*/
--- no_error_log
[error]
+
Review comment:
test case style: 3 blank lines between different test cases
##########
File path: t/plugin/prometheus.t
##########
@@ -534,3 +534,79 @@ GET /apisix/prometheus/metrics
qr/.*apisix_http_overhead_bucket.*/
--- no_error_log
[error]
+
+=== TEST 26: add service 3 to distinguish other services
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/services/3',
+ ngx.HTTP_PUT,
+ [[{
+ "plugins": {
+ "prometheus": {}
+ },
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1981": 1
+ },
+ "type": "roundrobin"
+ }
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
Review comment:
please use `reindex` tools to format your test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
