membphis commented on a change in pull request #1645:
URL: https://github.com/apache/incubator-apisix/pull/1645#discussion_r434942074
##########
File path: t/lib/server.lua
##########
@@ -28,6 +28,11 @@ function _M.hello1()
ngx.say("hello1 world")
end
+-- mock server for test the fix of overhead's value
+function _M.hello4()
Review comment:
we can reuse `sleep1`:
https://github.com/apache/incubator-apisix/blob/492880c05ee064ea7274b0b1cd52f00356eea04d/t/lib/server.lua#L68
you can take a look at:
https://github.com/apache/incubator-apisix/blob/master/t/node/timeout-upstream.t#L49
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
