spacewander commented on code in PR #7594:
URL: https://github.com/apache/apisix/pull/7594#discussion_r935351187
##########
t/node/upstream-ipv6.t:
##########
@@ -108,3 +108,187 @@ GET /hello
hello world
--- no_error_log
[error]
+
+
+
+=== TEST 5: set upstream(id: 1)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/upstreams/1',
+ ngx.HTTP_PUT,
+ [[{
+ "nodes": [
+ {
+ "weight": 100,
+ "priority": 0,
+ "host": "::1",
+ "port": 1980
+ }
+ ],
+ "type": "roundrobin",
+ "desc": "new upstream"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 6: hit routes
+--- request
+GET /hello
+--- response_body
+hello world
+--- no_error_log
+[error]
+
+
+
+=== TEST 7: set upstream(id: 1)
Review Comment:
Would be better to use a precise test name instead of repeating `set
upstream(id: 1)`. The first test in a group of tests should contain a title
that describes what is tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
