spacewander commented on code in PR #7594:
URL: https://github.com/apache/apisix/pull/7594#discussion_r936265169
##########
docs/en/latest/admin-api.md:
##########
@@ -524,7 +524,7 @@ In addition to the equalization algorithm selections,
Upstream also supports pas
| Name | Optional |
Description
| Example
|
| --------------------------- | ------------------------------------------- |
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
------------------------------------------------------------------------------------------------------------------------------------------
|
| type | required |
Load balancing algorithm to be used.
|
|
-| nodes | required, can't be used with `service_name` |
IP addresses (with optional ports) of the Upstream nodes represented as a hash
table or an array. If the IP address is IPv6 address, it (without port) must be
quoted with square brackets. In the hash table, the key is the IP address and
the value is the weight of the node for the load balancing algorithm. In the
array, each item is a hash table with keys `host`, `weight`, and the optional
`port` and `priority`. Empty nodes are treated as placeholders and clients
trying to access this Upstream will receive a 502 response.
| `192.168.1.100:80`, `[::1]:80`
|
+| nodes | required, can't be used with `service_name` |
IP addresses (with optional ports) of the Upstream nodes represented as a hash
table or an array. For hash table case, if the key is IPv6 address with port,
then the IPv6 address must be quoted with square brackets. In the hash table,
the key is the IP address and the value is the weight of the node for the load
balancing algorithm. In the array, each item is a hash table with keys `host`,
`weight`, and the optional `port` and `priority`. Empty nodes are treated as
placeholders and clients trying to access this Upstream will receive a 502
response.
| `192.168.1.100:80`, `[::1]:80`
|
Review Comment:
> For hash table case, if the key is IPv6 address with port, then the IPv6
address must be quoted with square brackets.
Could we move this sentence back so the English version is similar with the
Chinese version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
