nic-chen commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r469744994
##########
File path: apisix/core/config_etcd.lua
##########
@@ -48,14 +49,15 @@ local mt = {
return " etcd key: " .. self.key
end
}
+local etcd_version = _M.local_conf().etcd.version or "v2"
Review comment:
Create a new `config_etcd_v3.lua` for v3, instead of mixing the logic of
v2 and v3, it may be more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
