Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r469755712
##########
File path: apisix/core/config_etcd.lua
##########
@@ -48,14 +49,15 @@ local mt = {
return " etcd key: " .. self.key
end
}
+local etcd_version = _M.local_conf().etcd.version or "v2"
Review comment:
I thought config_etcd_v3.lua would reuse quite a lot code of
config_etcd.lua, it might result in difficulty in maintenance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
