tao12345666333 commented on code in PR #278:
URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r945091873
##########
charts/apisix/values.yaml:
##########
@@ -120,6 +120,14 @@ apisix:
nameOverride: ""
fullnameOverride: ""
+serviceAccount:
+ create: false # Set to `true` to create ServiceAccount for Kubernetes
service discovery.
+ annotations: {}
+ name: ""
+
+rbac:
+ create: false # Set to `true` to create RBAC resources for Kubernetes
service discovery.
Review Comment:
Since the configuration content here is actually tied to a specific feature
of APISIX, I recommend moving it to a section. It does not have the same
meaning or behavior as the configuration item of the same name in most Helm
charts
For example put it under `discovery.registry.kubernetes` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
