tao12345666333 commented on code in PR #278:
URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r948283960
##########
charts/apisix/values.yaml:
##########
@@ -120,6 +120,14 @@ apisix:
nameOverride: ""
fullnameOverride: ""
+serviceAccount:
+ create: false # Set to `true` to create ServiceAccount for Kubernetes
service discovery.
+ annotations: {}
+ name: ""
+
+rbac:
+ create: false # Set to `true` to create RBAC resources for Kubernetes
service discovery.
Review Comment:
> I think `serviceAccount` can stay at the same location, as its behavior is
the same as in other Helm charts.
ok
----
Another important thing comes to my mind, maybe I'm just bothered by your
title and comments.
We can simply align with other popular Charts.
Keep the following fields
* serviceAccount
* rbac
But don't associate them with APISIX's kubernetes discovery
Then we need a configuration for RBAC that handles kubernetes discovery
specifically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
