biubiue commented on code in PR #7782:
URL: https://github.com/apache/apisix/pull/7782#discussion_r955759131
##########
apisix/plugins/kafka-logger.lua:
##########
@@ -205,7 +215,8 @@ function _M.log(conf, ctx)
for host, port in pairs(conf.broker_list) do
local broker = {
host = host,
- port = port
+ port = port,
+ sasl_config = conf.sasl_config or nil
Review Comment:
> Would you please add test to cover it? To make things simple, you can
validate the behavior by injecting the producer.new and checking if sasl_config
is passed through.
>
> You can learn about the test framework with:
https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
