biubiue commented on code in PR #7782:
URL: https://github.com/apache/apisix/pull/7782#discussion_r965430180
##########
apisix/plugins/kafka-logger.lua:
##########
@@ -51,6 +51,16 @@ local schema = {
},
},
},
+ sasl_config = {
+ type = "object",
+ description = "sasl config",
+ properties = {
+ mechanism = { type = "string", description = "mechanism" },
+ password = { type = "string", description = "password" },
+ user = { type = "string", description = "user" },
Review Comment:
> These fields should be required if the sasl config exists?
I modify these fields ,and mark required fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]