biubiue commented on code in PR #7782:
URL: https://github.com/apache/apisix/pull/7782#discussion_r965447660
##########
apisix/plugins/kafka-logger.lua:
##########
@@ -51,6 +51,16 @@ local schema = {
},
},
},
+ sasl_config = {
+ type = "object",
+ description = "sasl config",
+ properties = {
+ mechanism = { type = "string", description = "mechanism",
default = "PLAIN" },
Review Comment:
> The `mechanism` should be restricted to only use a few enumerations like
`PLAIN`, `SCRAM` and so on.
Just now I review
[lua-resty-kafka](https://github.com/doujiang24/lua-resty-kafka) ,
Write this local MECHANISM_SCRAMSHA256 = "SCRAM-SHA-256" -- to do, so
SCRAM-SHA-256 maybe not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
