monkeyDluffy6017 commented on code in PR #7946:
URL: https://github.com/apache/apisix/pull/7946#discussion_r979498437
##########
t/tars/discovery/tars.t:
##########
@@ -41,8 +41,8 @@ discovery:
database: db_tars
user: root
password: tars2022
- full_fetch_interval: 3
- incremental_fetch_interval: 1
+ full_fetch_interval: 90
Review Comment:
The modification should be put before apisix = require("apisix")，the
validation is called in that.
##########
t/APISIX.pm:
##########
@@ -502,6 +503,8 @@ _EOC_
require "resty.core"
+ $extra_init_by_lua_start
Review Comment:
What do you ping me for?
##########
t/APISIX.pm:
##########
@@ -502,6 +503,8 @@ _EOC_
require "resty.core"
+ $extra_init_by_lua_start
Review Comment:
Some code chunk in test cases need to be placed after apisix =
require("apisix"), so we cannot just move $extra_init_by_lua
##########
t/APISIX.pm:
##########
@@ -502,6 +503,8 @@ _EOC_
require "resty.core"
+ $extra_init_by_lua_start
Review Comment:
Done
##########
t/APISIX.pm:
##########
@@ -502,6 +503,8 @@ _EOC_
require "resty.core"
+ $extra_init_by_lua_start
Review Comment:
Some code chunk in test cases need to be placed after `apisix =
require("apisix")`, so we cannot just move $extra_init_by_lua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
