spacewander commented on code in PR #7946:
URL: https://github.com/apache/apisix/pull/7946#discussion_r979501563
##########
t/APISIX.pm:
##########
@@ -493,6 +493,11 @@ _EOC_
$block->set_value("main_config", $main_config);
+ # The new directive is introduced here to modify the upper and
Review Comment:
We can modify the schema, not only the upper and lower limits
##########
t/APISIX.pm:
##########
@@ -493,6 +493,11 @@ _EOC_
$block->set_value("main_config", $main_config);
+ # The new directive is introduced here to modify the upper and
+ # lower limits of the schema before apisix validate in require("apisix")
+ # Todo: merge extra_init_by_lua_start and extra_init_by_lua
Review Comment:
Maybe we should also create a new issue for this tech debt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
