kingluo commented on code in PR #7980:
URL: https://github.com/apache/apisix/pull/7980#discussion_r979510285
##########
apisix/plugin.lua:
##########
@@ -651,20 +665,33 @@ local function merge_consumer_route(route_conf,
consumer_conf)
end
-function _M.merge_consumer_route(route_conf, consumer_conf, api_ctx)
+function _M.merge_consumer_route(route_conf, consumer_conf,
consumer_group_conf, api_ctx)
core.log.info("route conf: ", core.json.delay_encode(route_conf))
core.log.info("consumer conf: ", core.json.delay_encode(consumer_conf))
+ core.log.info("consumer group conf: ",
core.json.delay_encode(consumer_group_conf))
local flag = route_conf.value.id .. "#" .. route_conf.modifiedIndex
.. "#" .. consumer_conf.id .. "#" ..
consumer_conf.modifiedIndex
+
+ if consumer_group_conf then
+ flag = flag .. "#" .. consumer_group_conf.value.id
+ .. "#" .. consumer_group_conf.modifiedIndex
Review Comment:
I already does. It concats new identification to the exist flag, which
already contains route stuff.
```lua
-- check here...
local flag = route_conf.value.id .. "#" .. route_conf.modifiedIndex
.. "#" .. consumer_conf.id .. "#" ..
consumer_conf.modifiedIndex
if consumer_group_conf then
flag = flag .. "#" .. consumer_group_conf.value.id
.. "#" .. consumer_group_conf.modifiedIndex
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
