spacewander commented on code in PR #7980:
URL: https://github.com/apache/apisix/pull/7980#discussion_r980781612
##########
apisix/admin/consumers.lua:
##########
@@ -62,6 +63,12 @@ local function check_conf(username, conf)
end
end
+ if conf.group_id then
+ if consumer_group.get(conf.group_id) == nil then
Review Comment:
For code style, I will recommend using the same solution in
https://github.com/apache/apisix/blob/3c18031c6e70daa15db72fe06ae8644b04b4481e/apisix/admin/routes.lua#L79
1. fetch the data from etcd if possible
2. use a similar error message
##########
apisix/core/ctx.lua:
##########
@@ -207,6 +207,7 @@ do
balancer_ip = true,
balancer_port = true,
consumer_name = true,
+ consumer_group_id = true,
Review Comment:
For alphabetical order, the `consumer_group_id` is ahead of consumer_name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
