Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477333950
##########
File path: t/core/etcd-auth.t
##########
@@ -18,23 +18,28 @@ BEGIN {
$ENV{"ETCD_ENABLE_AUTH"} = "true"
}
-use t::APISIX 'no_plan';
+use t::APISIX;
repeat_each(1);
no_long_string();
no_root_location();
log_level("info");
-# Authentication is enabled at etcd and credentials are set
-system('etcdctl --endpoints="http://127.0.0.1:2379"; -u root:5tHkHhYkjr6cQY
user add root:5tHkHhYkjr6cQY');
-system('etcdctl --endpoints="http://127.0.0.1:2379"; -u root:5tHkHhYkjr6cQY
auth enable');
-system('etcdctl --endpoints="http://127.0.0.1:2379"; -u root:5tHkHhYkjr6cQY
role revoke --path "/*" -rw guest');
+my $etcd_version = `etcdctl version`;
+if ($etcd_version =~ /etcdctl version: 3.2/) {
+ plan(skip_all => "skip for etcd version v3.2");
+} else {
Review comment:
I'm not so sure about this. I couldn't find relevant changes in etcd
v3.3 CHANGELOG. I did this because 1. the lua-resty-etcd side auth test also
skips v3.2 and 2. there are errors using the current test in v3.2.
I'm in a hurry these days and I'll fix it later. I think it could be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
