moonming commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-681198221


   > No, apisix and etcd will not in the same machine. Shuyang Wu 
<[email protected]> 于 2020年8月26日周三 下午9:51写道:
   > […](#)
   > *@Yiyiyimu* commented on this pull request. ------------------------------ 
In apisix/core/etcd.lua <[#2036 
(comment)](https://github.com/apache/apisix/pull/2036#discussion_r477316914)>: 
> local _M = {version = 0.1} +local prefix_v3 = { + ["3.5"] = "/v3", + ["3.4"] 
= "/v3", + ["3.3"] = "/v3beta", + ["3.2"] = "/v3alpha", +} + + +-- TODO: 
Default lua-resty-etcd version auto-detection is broken, so directly get 
version from cmd +-- we don't need to call this so many times, need to save it 
in some place +local function etcd_version_from_cmd() + local cmd = "export 
ETCDCTL_API=3 && etcdctl version" etcdctl would be installed alongside with 
etcd — You are receiving this because you were mentioned. Reply to this email 
directly, view it on GitHub <[#2036 
(comment)](https://github.com/apache/apisix/pull/2036#discussion_r477316914)>, 
or unsubscribe 
<https://github.com/notifications/unsubscribe-auth/AGJZBKZIYJTOHVGJMEI3IGDSCUHPJANCNFSM4P2AS3KQ>
 .
   
   I created  a new issue for this: 
https://github.com/apache/apisix/issues/2125, CI should be adjusted to find 
such problems


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to