tokers commented on code in PR #8433:
URL: https://github.com/apache/apisix/pull/8433#discussion_r1035816967
##########
Makefile:
##########
@@ -153,6 +156,7 @@ deps: runtime
mkdir -p ~/.luarocks; \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_LIBDIR $(addprefix $(ENV_OPENSSL_PREFIX), /lib); \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_INCDIR $(addprefix $(ENV_OPENSSL_PREFIX), /include); \
+ $(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.PCRE_INCDIR $(addprefix $(ENV_PCRE_PREFIX), /include); \
Review Comment:
The variable `ENV_PCRE_PREFIX` will only be set in darwin, so this command
should be conditional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
