drgnchan commented on code in PR #8433:
URL: https://github.com/apache/apisix/pull/8433#discussion_r1035918427
##########
Makefile:
##########
@@ -153,6 +156,7 @@ deps: runtime
mkdir -p ~/.luarocks; \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_LIBDIR $(addprefix $(ENV_OPENSSL_PREFIX), /lib); \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_INCDIR $(addprefix $(ENV_OPENSSL_PREFIX), /include); \
+ $(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.PCRE_INCDIR $(addprefix $(ENV_PCRE_PREFIX), /include); \
Review Comment:
Thank you for the reminder.Actually I found `pcre.h` in `/usr/include` in my
Ubuntu vm.I will wrap this line by an `ifeq` condition for darwin.What do you
think of the condition i am going to add?Is it enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
