drgnchan commented on code in PR #8433:
URL: https://github.com/apache/apisix/pull/8433#discussion_r1039107817
##########
Makefile:
##########
@@ -153,6 +156,7 @@ deps: runtime
mkdir -p ~/.luarocks; \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_LIBDIR $(addprefix $(ENV_OPENSSL_PREFIX), /lib); \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_INCDIR $(addprefix $(ENV_OPENSSL_PREFIX), /include); \
+ [ '$(ENV_OS_NAME)' == 'darwin' ] && $(ENV_LUAROCKS) config
$(ENV_LUAROCKS_FLAG_LOCAL) variables.PCRE_INCDIR $(addprefix
$(ENV_PCRE_PREFIX), /include); \
Review Comment:
> try with
>
> ```
> [ '$(ENV_OS_NAME)' == 'darwin' ] && $(ENV_LUAROCKS) config
$(ENV_LUAROCKS_FLAG_LOCAL) variables.PCRE_DIR $(addprefix $(ENV_PCRE_PREFIX),
/lib); \
> ```
Your command assign variable `PCRE_DIR` with value of
`$(ENV_PCRE_PREFIX)/lib`.But I found in rockspec file
`lrexlib-pcre-2.9.1-1.rockspec` that `libdirs` use variable `PCRE_LIBDIR`.
```
build = {
type = "builtin",
modules = {
rex_pcre = {
defines = {
"VERSION=\"2.9.1\"",
"PCRE2_CODE_UNIT_WIDTH=8",
},
sources = {
"src/common.c",
"src/pcre/lpcre.c",
"src/pcre/lpcre_f.c",
},
libraries = {
"pcre",
},
incdirs = {
"$(PCRE_INCDIR)",
},
libdirs = {
"$(PCRE_LIBDIR)",
},
},
},
}
external_dependencies = {
PCRE = {
header = "pcre.h",
library = "pcre",
},
}
dependencies = {
"lua >= 5.1",
}
source = {
tag = "rel-2-9-1",
url = "git://github.com/rrthomas/lrexlib.git",
}
description = {
homepage = "http://github.com/rrthomas/lrexlib";,
license = "MIT/X11",
detailed = "Lrexlib is a regular expression library for Lua 5.1-5.4, which\
provides bindings for several regular expression libraries.\
This rock provides the PCRE bindings.",
summary = "Regular expression library binding (PCRE flavour).",
}
version = "2.9.1-1"
package = "Lrexlib-PCRE"
```
Should the `PCRE_DIR` be replaced by `PCRE_LIBDIR` in the command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
