tzssangglass commented on code in PR #8433:
URL: https://github.com/apache/apisix/pull/8433#discussion_r1039127172
##########
Makefile:
##########
@@ -153,6 +156,7 @@ deps: runtime
mkdir -p ~/.luarocks; \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_LIBDIR $(addprefix $(ENV_OPENSSL_PREFIX), /lib); \
$(ENV_LUAROCKS) config $(ENV_LUAROCKS_FLAG_LOCAL)
variables.OPENSSL_INCDIR $(addprefix $(ENV_OPENSSL_PREFIX), /include); \
+ [ '$(ENV_OS_NAME)' == 'darwin' ] && $(ENV_LUAROCKS) config
$(ENV_LUAROCKS_FLAG_LOCAL) variables.PCRE_INCDIR $(addprefix
$(ENV_PCRE_PREFIX), /include); \
Review Comment:
form the error message https://github.com/apache/apisix/issues/4945
```
You may have to install PCRE in your system and/or pass PCRE_DIR or
PCRE_INCDIR to the luarocks command.
```
sorry, forget what I said, it looks like we only need one of PCRE_DIR or
PCRE_INCDIR.
I test this PR on macOS(amd64), and it works well.
so we can remove
```
[ '$(ENV_OS_NAME)' == 'darwin' ] && $(ENV_LUAROCKS) config
$(ENV_LUAROCKS_FLAG_LOCAL) variables.PCRE_LIBDIR $(addprefix
$(ENV_PCRE_PREFIX), /lib); \
```
BTW, I need to add
```
LDAP_DIR = "/usr/local/opt/openldap",
LDAP_INCDIR = "/usr/local/opt/openldap/include",
```
to `~/.luarocks/config-5.1.lua`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
