soulbird commented on code in PR #8604:
URL: https://github.com/apache/apisix/pull/8604#discussion_r1061187611


##########
apisix/plugins/elasticsearch-logger.lua:
##########
@@ -31,10 +32,19 @@ local batch_processor_manager = 
bp_manager_mod.new(plugin_name)
 local schema = {
     type = "object",
     properties = {
+        -- deprecated, use "endpoint_addrs" instead
         endpoint_addr = {
             type = "string",
             pattern = "[^/]$",
         },
+        endpoint_addrs = {

Review Comment:
   Extending endpoint_addr in a compatible way, and adding a new configuration 
is not a good choice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to