xiaoxuanzi commented on code in PR #8604:
URL: https://github.com/apache/apisix/pull/8604#discussion_r1066602474
##########
apisix/plugins/elasticsearch-logger.lua:
##########
@@ -31,10 +32,19 @@ local batch_processor_manager =
bp_manager_mod.new(plugin_name)
local schema = {
type = "object",
properties = {
+ -- deprecated, use "endpoint_addrs" instead
endpoint_addr = {
type = "string",
pattern = "[^/]$",
},
+ endpoint_addrs = {
Review Comment:
Hi @soulbird.
I fixed the code according to your suggestion. please review it.
##########
apisix/plugins/elasticsearch-logger.lua:
##########
@@ -31,10 +32,19 @@ local batch_processor_manager =
bp_manager_mod.new(plugin_name)
local schema = {
type = "object",
properties = {
+ -- deprecated, use "endpoint_addrs" instead
endpoint_addr = {
type = "string",
pattern = "[^/]$",
},
+ endpoint_addrs = {
Review Comment:
> Looking at this, it also indicates the need to unify into one. You can
refer to the definition of nodes_schema to allow endpoint_addrs to be set to
multiple types:
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L289
Thanks for the helpful advice!
Hi @soulbird.
I fixed the code according to your suggestion. please review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
