moonming commented on a change in pull request #454:
URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484648821
##########
File path: .github/workflows/api_ci.yml
##########
@@ -74,3 +74,7 @@ jobs:
working-directory: ./api
run: |
go test ./...
+
+ - name: run Makefile
+ run: |
+ sudo make license-check
Review comment:
why add `sudo`?
##########
File path: .travis.yml
##########
@@ -0,0 +1,49 @@
+dist: bionic
Review comment:
we using github actions, not travis as CI
##########
File path: .travis/ASF-Release.cfg
##########
@@ -0,0 +1,105 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+# scanCode.py configuration file
+
+# List of filenames containing the text of valid license (headers)
+# These files SHOULD be in the same directory path where scanCode.py
+# resides.
+[Licenses]
+ASFLicenseHeader.txt
+ASFLicenseHeaderBash.txt
+ASFLicenseHeaderMarkdown.txt
+ASFLicenseHeaderLua.txt
+
+# Filters (path/filename) with wildcards and associated scan checks
+# that are to be run against them. The checks are actual valid
+# function names found in scanCode.py.
+[Includes]
+*=is_not_symlink, regex_check
+*.conf=has_block_license, eol_at_eof, regex_check
+*.go=has_block_license, eol_at_eof, regex_check
+*.gradle=has_block_license, eol_at_eof, regex_check
+*.groovy=has_block_license, eol_at_eof, regex_check
+*.html=has_block_license, regex_check
+*.java=no_tabs, has_block_license, eol_at_eof, regex_check
+*.js=has_block_license, regex_check
+*.lua=has_block_license, eol_at_eof, regex_check
+*.md=no_tabs, has_block_license, eol_at_eof, regex_check
+*.properties=no_tabs, has_block_license, eol_at_eof, regex_check
+*.py=no_tabs, has_block_license, eol_at_eof, regex_check
+*.scala=has_block_license, no_tabs, eol_at_eof, regex_check
+*.sh=has_block_license, eol_at_eof, regex_check
+*.swift=no_tabs, has_block_license, eol_at_eof, regex_check
+*.yaml=has_block_license, eol_at_eof, regex_check
+*.yml=has_block_license, eol_at_eof, regex_check
+*.css=has_block_license, regex_check
+*Dockerfile*=has_block_license
+
+# for test case files of test::nginx
+*.t=has_block_license, eol_at_eof, regex_check
+*.pm=has_block_license, eol_at_eof, regex_check
+
+# for APISIX CLI
+*/bin/apisix=has_block_license, eol_at_eof, regex_check
+
+# for luarocks spec files
+*.rockspec=has_block_license, eol_at_eof, regex_check
+
+# Sanity check files not required to have ASF headers because either they
+# are excluded or are not packaged with the Apache source release.
+*.cfg=regex_check
+*.ini=regex_check
+*.j2=regex_check
+*.json=regex_check
+*.txt=regex_check
+*.xml=regex_check
+
+# List of paths (inclusive of subdirectories) to exclude from code scanning
+[Excludes]
+
+# General tooling & binary file exclusions
+.bin
+.dockerignore
+.eslintrc.*
+.git
+.gitattributes
+.github
+.gitignore
+.gradle
+.idea
+.jshintrc
+.pydevproject
+.rat-excludes
+.tox
+
+# Exclude Apache standard legal files
+CREDITS.txt
+DISCLAIMER.txt
+LICENSE*.txt
+NOTICE.txt
+
+# Exclude travis CI files
+build-cache
+deps
+test-nginx
+grpc_server_example
+.travis.yml
+grpcurl
+t/servroot
+
+conf
+.travis/openwhisk-utilities
+
+# Exclude dashboard files
+dashboard
Review comment:
this repo not has `dashborad` dir
##########
File path: .travis/ASF-Release.cfg
##########
@@ -0,0 +1,105 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+# scanCode.py configuration file
+
+# List of filenames containing the text of valid license (headers)
+# These files SHOULD be in the same directory path where scanCode.py
+# resides.
+[Licenses]
+ASFLicenseHeader.txt
+ASFLicenseHeaderBash.txt
+ASFLicenseHeaderMarkdown.txt
+ASFLicenseHeaderLua.txt
+
+# Filters (path/filename) with wildcards and associated scan checks
+# that are to be run against them. The checks are actual valid
+# function names found in scanCode.py.
+[Includes]
+*=is_not_symlink, regex_check
+*.conf=has_block_license, eol_at_eof, regex_check
+*.go=has_block_license, eol_at_eof, regex_check
+*.gradle=has_block_license, eol_at_eof, regex_check
+*.groovy=has_block_license, eol_at_eof, regex_check
+*.html=has_block_license, regex_check
+*.java=no_tabs, has_block_license, eol_at_eof, regex_check
+*.js=has_block_license, regex_check
+*.lua=has_block_license, eol_at_eof, regex_check
+*.md=no_tabs, has_block_license, eol_at_eof, regex_check
+*.properties=no_tabs, has_block_license, eol_at_eof, regex_check
+*.py=no_tabs, has_block_license, eol_at_eof, regex_check
+*.scala=has_block_license, no_tabs, eol_at_eof, regex_check
+*.sh=has_block_license, eol_at_eof, regex_check
+*.swift=no_tabs, has_block_license, eol_at_eof, regex_check
+*.yaml=has_block_license, eol_at_eof, regex_check
+*.yml=has_block_license, eol_at_eof, regex_check
+*.css=has_block_license, regex_check
+*Dockerfile*=has_block_license
+
+# for test case files of test::nginx
+*.t=has_block_license, eol_at_eof, regex_check
+*.pm=has_block_license, eol_at_eof, regex_check
+
+# for APISIX CLI
+*/bin/apisix=has_block_license, eol_at_eof, regex_check
+
+# for luarocks spec files
+*.rockspec=has_block_license, eol_at_eof, regex_check
+
+# Sanity check files not required to have ASF headers because either they
+# are excluded or are not packaged with the Apache source release.
+*.cfg=regex_check
+*.ini=regex_check
+*.j2=regex_check
+*.json=regex_check
+*.txt=regex_check
+*.xml=regex_check
+
+# List of paths (inclusive of subdirectories) to exclude from code scanning
+[Excludes]
+
+# General tooling & binary file exclusions
+.bin
+.dockerignore
+.eslintrc.*
+.git
+.gitattributes
+.github
+.gitignore
+.gradle
+.idea
+.jshintrc
+.pydevproject
+.rat-excludes
+.tox
+
+# Exclude Apache standard legal files
+CREDITS.txt
+DISCLAIMER.txt
+LICENSE*.txt
+NOTICE.txt
+
+# Exclude travis CI files
+build-cache
+deps
+test-nginx
+grpc_server_example
+.travis.yml
+grpcurl
+t/servroot
+
Review comment:
we don't have those dirs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
