moonming commented on a change in pull request #454:
URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484720845
##########
File path: Makefile
##########
@@ -0,0 +1,8 @@
+### license-check: Check apisix-dashboard source code for Apache License
+.PHONY: license-check
+license-check:
+ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
+ git clone https://github.com/apache/openwhisk-utilities.git
.travis/openwhisk-utilities
+ cp .travis/ASF* .travis/openwhisk-utilities/scancode/
Review comment:
please take a better name, this PR is nothing with travis.
##########
File path: .travis/ASF-Release.cfg
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+
+# scanCode.py configuration file
+
+# List of filenames containing the text of valid license (headers)
+# These files SHOULD be in the same directory path where scanCode.py
+# resides.
+[Licenses]
+ASFLicenseHeader.txt
+ASFLicenseHeaderBash.txt
+ASFLicenseHeaderMarkdown.txt
+ASFLicenseHeaderLua.txt
+
+# Filters (path/filename) with wildcards and associated scan checks
+# that are to be run against them. The checks are actual valid
+# function names found in scanCode.py.
+[Includes]
+*=is_not_symlink, regex_check
+*.conf=has_block_license, eol_at_eof, regex_check
+*.go=has_block_license, eol_at_eof, regex_check
+*.gradle=has_block_license, eol_at_eof, regex_check
+*.groovy=has_block_license, eol_at_eof, regex_check
+*.html=has_block_license, regex_check
+*.java=no_tabs, has_block_license, eol_at_eof, regex_check
+*.js=has_block_license, regex_check
+*.lua=has_block_license, eol_at_eof, regex_check
+*.md=no_tabs, has_block_license, eol_at_eof, regex_check
+*.properties=no_tabs, has_block_license, eol_at_eof, regex_check
+*.py=no_tabs, has_block_license, eol_at_eof, regex_check
+*.scala=has_block_license, no_tabs, eol_at_eof, regex_check
+*.sh=has_block_license, eol_at_eof, regex_check
+*.swift=no_tabs, has_block_license, eol_at_eof, regex_check
+*.yaml=has_block_license, eol_at_eof, regex_check
+*.yml=has_block_license, eol_at_eof, regex_check
+*.css=has_block_license, regex_check
+*Dockerfile*=has_block_license
+
+# for test case files of test::nginx
+*.t=has_block_license, eol_at_eof, regex_check
+*.pm=has_block_license, eol_at_eof, regex_check
+
+# for APISIX CLI
+*/bin/apisix=has_block_license, eol_at_eof, regex_check
+
+# for luarocks spec files
+*.rockspec=has_block_license, eol_at_eof, regex_check
+
Review comment:
please check all lines in this file, only keep what you need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]