Fabriceli commented on code in PR #8651:
URL: https://github.com/apache/apisix/pull/8651#discussion_r1068996136
##########
t/discovery/consul_dump.t:
##########
@@ -161,6 +165,8 @@ discovery:
consul:
servers:
- "http://127.0.0.1:38500";
+ skip_services:
+ - "consul"
Review Comment:
Yes, consul will be registered by default. I dont think it would be better
if we skip it by default. We can give users to choice whether to skip or not,
that can be closed-loop control. Of course, we should mention this info in
Consul doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
