spacewander commented on code in PR #8651:
URL: https://github.com/apache/apisix/pull/8651#discussion_r1070872016
##########
t/discovery/consul_dump.t:
##########
@@ -161,6 +165,8 @@ discovery:
consul:
servers:
- "http://127.0.0.1:38500";
+ skip_services:
+ - "consul"
Review Comment:
Is it a good idea? If consul is not skipped by default, people will need to
repeat the same configuration each time they need to use consul discovery,
similar to the `proxy_http_version 1.1` in the Nginx conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
