ZUOXIANGE commented on code in PR #8758:
URL: https://github.com/apache/apisix/pull/8758#discussion_r1091628937


##########
apisix/plugins/request-id.lua:
##########
@@ -218,7 +219,18 @@ function _M.rewrite(conf, ctx)
     local headers = ngx.req.get_headers()
     local uuid_val
     if not headers[conf.header_name] then
-        uuid_val = get_request_id(conf.algorithm)
+        -- request-id support get from query string
+        if conf.get_from_query then
+            local querystring = ngx.req.get_uri_args()
+            if not querystring[conf.header_name] then

Review Comment:
   Add an `id-name` parameter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to