tokers commented on code in PR #8758:
URL: https://github.com/apache/apisix/pull/8758#discussion_r1092658061
##########
apisix/plugins/request-id.lua:
##########
@@ -40,7 +40,9 @@ local schema = {
properties = {
header_name = {type = "string", default = "X-Request-Id"},
include_in_response = {type = "boolean", default = true},
- algorithm = {type = "string", enum = {"uuid", "snowflake", "nanoid"},
default = "uuid"}
+ algorithm = {type = "string", enum = {"uuid", "snowflake", "nanoid"},
default = "uuid"},
+ id_name = {type = "string", default = "req-id"},
+ get_from_query = {type = "boolean", default = false}
Review Comment:
I think this two fields can be merged into one: `"arg_name"`, which will be
better since we already have a `header_name` field, and they're exclusive from
each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
