spacewander commented on code in PR #8681:
URL: https://github.com/apache/apisix/pull/8681#discussion_r1096914898
##########
apisix/cli/util.lua:
##########
@@ -38,10 +38,9 @@ local function execute_cmd(cmd)
local data, err = t:read("*all")
t:close()
-
if not data then
return nil, "failed to read execution result of: "
- .. cmd .. ", error info: " .. err
Review Comment:
Please don't remove blank line and break the indentation
##########
t/cli/plugin/test_file_logger_std_output.sh:
##########
@@ -0,0 +1,81 @@
+#!/usr/bin/env bash
Review Comment:
Is this test run in the CI?
https://github.com/apache/apisix/blob/d019da018ca8c06bf80e363a0512a30808da1b8e/ci/linux_apisix_current_luarocks_runner.sh#L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
