tokers commented on code in PR #461:
URL: https://github.com/apache/apisix-helm-chart/pull/461#discussion_r1098403671
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -45,7 +45,9 @@ data:
{{- end }}
{{- else }}
apisix: # universal configurations
+ {{- if not (eq .Values.deployment.mode "control_plane") }}
Review Comment:
Should also check this for SSL ports.
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -250,9 +252,24 @@ data:
{{- end }}
deployment:
- role: traditional
+ role: {{ .Values.deployment.role }}
+ {{- if or (eq .Values.deployment.role "traditional") (eq
.Values.deployment.role "control_plane") }}
+
+ {{- if eq .Values.deployment.role "traditional" }}
role_traditional:
config_provider: etcd
+ {{- end }}
+
+ {{- if eq .Values.deployment.role "control_plane" }}
Review Comment:
Else if?
##########
charts/apisix/values.yaml:
##########
@@ -168,6 +168,42 @@ serviceAccount:
rbac:
create: false
+deployment:
+ # -- Apache APISIX deployment mode
+ # Optional: traditional, decoupled
+ #
+ # ref: https://apisix.apache.org/docs/apisix/deployment-modes/
+ mode: traditional
+
+ # -- Deployment role
+ # Optional: traditional, data_plane, control_plane
+ #
+ # ref: https://apisix.apache.org/docs/apisix/deployment-modes/
+ role: "traditional"
+
+ # -- used for control_plane deployment mode
+ controlPlane:
+ # -- conf Server address
+ confServerListen: "0.0.0.0:9280"
+ # -- secret name used by conf Server
+ certsSecret: ""
+ # -- conf Server CA cert name
+ cert: ""
Review Comment:
What's the correlation of these three filenames and the keys in the secret
object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
