tao12345666333 commented on code in PR #461:
URL: https://github.com/apache/apisix-helm-chart/pull/461#discussion_r1099594682
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -250,9 +252,26 @@ data:
{{- end }}
deployment:
- role: traditional
+ role: {{ .Values.deployment.role }}
+ {{- if or (eq .Values.deployment.role "traditional") (eq
.Values.deployment.role "control_plane") }}
Review Comment:
no, Although traditional mode and role values are the same. But here, in
order to maintain the unity of logic, we choose to judge the role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
