[GitHub] [apisix] Qiuqiu0505 commented on a diff in pull request #9028: fix: If allow_origins_by_regex is not nil, should be considered to allow_origins_by_regex only

Tue, 14 Mar 2023 19:25:02 -0700 


Qiuqiu0505 commented on code in PR #9028:
URL: https://github.com/apache/apisix/pull/9028#discussion_r1136464300


##########
apisix/plugins/cors.lua:
##########
@@ -297,13 +297,13 @@ end
 
 function _M.header_filter(conf, ctx)
     local req_origin =  ctx.original_request_origin
-    -- Try allow_origins first, if mismatched, try allow_origins_by_regex.
+    -- If allow_origins_by_regex is not nil, should be matched to it only
     local allow_origins
-    allow_origins = process_with_allow_origins(conf.allow_origins, ctx, 
req_origin)
-    if not match_origins(req_origin, allow_origins) then
-        allow_origins = process_with_allow_origins_by_regex(conf, ctx, 
req_origin)
+    allow_origins = process_with_allow_origins_by_regex(conf, ctx, req_origin)

Review Comment:
   
![image](https://user-images.githubusercontent.com/110583072/225187467-e4099caa-7c13-4671-b8ff-f57514ac0447.png)
   
   This function named  process_with_allow_origins_by_regex has checked  
whether allow_origins_by_regex is  nil. 
   Does it need to be checked again before the method invocation? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to