spacewander commented on code in PR #9028:
URL: https://github.com/apache/apisix/pull/9028#discussion_r1138019353
##########
apisix/plugins/cors.lua:
##########
@@ -297,13 +297,13 @@ end
function _M.header_filter(conf, ctx)
local req_origin = ctx.original_request_origin
- -- Try allow_origins first, if mismatched, try allow_origins_by_regex.
+ -- If allow_origins_by_regex is not nil, should be matched to it only
local allow_origins
- allow_origins = process_with_allow_origins(conf.allow_origins, ctx,
req_origin)
- if not match_origins(req_origin, allow_origins) then
- allow_origins = process_with_allow_origins_by_regex(conf, ctx,
req_origin)
+ allow_origins = process_with_allow_origins_by_regex(conf, ctx, req_origin)
Review Comment:
Yes. We can move it out, and avoid the repeated `and
conf.allow_origins_by_regex == nil` check below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
