shreemaan-abhishek commented on code in PR #8620:
URL: https://github.com/apache/apisix/pull/8620#discussion_r1263625274
##########
apisix/plugins/log-rotate.lua:
##########
@@ -277,6 +277,7 @@ local function rotate()
max_size = attr.max_size or max_size
enable_compression = attr.enable_compression or enable_compression
end
+ local timeout = interval * 100 -- Timeout for compression is interval in
milliseconds
Review Comment:
@alptugay, I agree with you, however setting a fixed timeout is
inappropriate. What if the compression starts just before the next rotation?
The correct way would be to provide a timeout such that timeout occurs
before the next log-rotation. And if the compression still gets a timeout, we
can reschedule the compression later using ngx_timer. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
