monkeyDluffy6017 commented on code in PR #8620:
URL: https://github.com/apache/apisix/pull/8620#discussion_r1271996324
##########
apisix/plugins/log-rotate.lua:
##########
@@ -277,6 +277,7 @@ local function rotate()
max_size = attr.max_size or max_size
enable_compression = attr.enable_compression or enable_compression
end
+ local timeout = interval * 100 -- Timeout for compression is interval in
milliseconds
Review Comment:
I suggest adding a configuration to control the timeout parameter, the
default timeout is 10s, it's enough for most people, if you use interval as
timeout, it could be 1min or 1 hour, maybe someone don't need such long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
