shreemaan-abhishek commented on code in PR #9999: URL: https://github.com/apache/apisix/pull/9999#discussion_r1300858124
########## docs/en/latest/terminology/global-rule.md: ########## @@ -32,6 +32,12 @@ A [Plugin](./plugin.md) configuration can be bound directly to a [Route](./route Compared with the plugin configuration in Route, Service, Plugin Config, and Consumer, the plugin in the Global Rules is always executed first. +::: note + +Global Rules do not apply for Stream Routes. Review Comment: Oh, I missed this part of the code, however, stream routes would only cover the plugins in the `global_rules` that run on the `before_proxy` phase. https://github.com/shreemaan-abhishek/apisix/blob/9276e64fbd967967c1c9d33e0bb443c21a6021cb/apisix/init.lua#L1058 Do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
