kayx23 commented on code in PR #9999: URL: https://github.com/apache/apisix/pull/9999#discussion_r1302340919
########## docs/en/latest/terminology/plugin-config.md: ########## @@ -30,7 +30,7 @@ description: Plugin Config in Apache APISIX. Plugin Configs are used to extract commonly used [Plugin](./plugin.md) configurations and can be bound directly to a [Route](./route.md). -While configuring the same plugin, only one copy of the configuration is valid. The order of precedence is always `Consumer` > `Consumer Group` > `Route` > `Plugin Config` > `Service`. +While configuring the same plugin, only one copy of the configuration is valid. The order of precedence is always `Consumer` > `Consumer Group` > `Route` > `Plugin Config` > `Service`. Plugins configured in `Global Rules` will be executed first at all times. Review Comment: I suggest to leverage these information when it comes to plugin execution orders and precedence, to avoid update anomalies. * https://apisix.apache.org/docs/apisix/next/terminology/plugin/#plugins-merging-precedence * https://apisix.apache.org/docs/apisix/next/terminology/plugin/#plugins-execution-order ########## docs/en/latest/tutorials/protect-api.md: ########## @@ -37,7 +37,7 @@ This represents the configuration of the plugins that are executed during the HT :::note -If [Route](../terminology/route.md), [Service](../terminology/service.md), [Plugin Config](../terminology/plugin-config.md) or Consumer are all bound to the same for plugins, only one plugin configuration will take effect. The priority of plugin configurations is: Consumer > Route > Plugin Config > Service. At the same time, there are 6 stages involved in the plugin execution process, namely `rewrite`, `access`, `before_proxy`, `header_filter`, `body_filter` and `log`. +If [Route](../terminology/route.md), [Service](../terminology/service.md), [Plugin Config](../terminology/plugin-config.md) or Consumer are all bound to the same for plugins, only one plugin configuration will take effect. The priority of plugin configurations is: `Consumer` > `Route` > `Plugin Config` > `Service`. Plugins configured in `Global Rules` will be executed first at all times. At the same time, there are 6 stages involved in the plugin execution process, namely `rewrite`, `access`, `before_proxy`, `header_filter`, `body_filter` and `log`. Review Comment: ```suggestion If [Route](../terminology/route.md), [Service](../terminology/service.md), [Plugin Config](../terminology/plugin-config.md) or Consumer are all bound to the same for plugins, only one plugin configuration will take effect. The priority of plugin configurations is: `Consumer` > `Consumer Group` > `Route` > `Plugin Config` > `Service`. Plugins configured in `Global Rules` will be executed first at all times. At the same time, there are 6 stages involved in the plugin execution process, namely `rewrite`, `access`, `before_proxy`, `header_filter`, `body_filter` and `log`. ``` ########## docs/en/latest/tutorials/protect-api.md: ########## @@ -37,7 +37,7 @@ This represents the configuration of the plugins that are executed during the HT :::note -If [Route](../terminology/route.md), [Service](../terminology/service.md), [Plugin Config](../terminology/plugin-config.md) or Consumer are all bound to the same for plugins, only one plugin configuration will take effect. The priority of plugin configurations is: Consumer > Route > Plugin Config > Service. At the same time, there are 6 stages involved in the plugin execution process, namely `rewrite`, `access`, `before_proxy`, `header_filter`, `body_filter` and `log`. +If [Route](../terminology/route.md), [Service](../terminology/service.md), [Plugin Config](../terminology/plugin-config.md) or Consumer are all bound to the same for plugins, only one plugin configuration will take effect. The priority of plugin configurations is: `Consumer` > `Route` > `Plugin Config` > `Service`. Plugins configured in `Global Rules` will be executed first at all times. At the same time, there are 6 stages involved in the plugin execution process, namely `rewrite`, `access`, `before_proxy`, `header_filter`, `body_filter` and `log`. Review Comment: This entire block of note is explained in: * https://apisix.apache.org/docs/apisix/next/terminology/plugin/#plugins-merging-precedence * https://apisix.apache.org/docs/apisix/next/terminology/plugin/#plugins-execution-order * https://apisix.apache.org/docs/apisix/next/terminology/plugin/#plugins-execution-lifecycle I suggest we link to content in these links instead of update anomaly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
