membphis commented on pull request #2307: URL: https://github.com/apache/apisix/pull/2307#issuecomment-698348564
@ShiningRush > I am also curious about what scenarios need metadata instead of plugin's option. Here is the answer: https://github.com/apache/apisix/pull/2307#issuecomment-698337991 BTW, here is the old way to support the default value for log-rotate plugin: https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L199-L202 this way is not firendly: 1. local file, if we want to update it, we need to update the file and reload APISIX instance. 2. no schema, the user may set a wong value. 3. each plugin needs to check the default value if it is right by itself. but the `/apisix/plugin_metadata` fixed all of them, it is a standard way to set a default value for each plugin. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
