membphis commented on pull request #2307:
URL: https://github.com/apache/apisix/pull/2307#issuecomment-698354733


   > I think it may be easier to understand if it is called `ShareData` or 
other meaningful name.
   
   that is the another PR which implemented the `plugin_metadata`: 
https://github.com/apache/apisix/pull/2268
   
   `/apisix/plugin_metadata/http-logger` -> `{log_format: {....}}`
   
   this value only can be used in plugin `http-logger`, it can not be used for 
other plugin. 
   so I think `ShareData` is not a good name for this case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to