Vacant2333 commented on code in PR #10729:
URL: https://github.com/apache/apisix/pull/10729#discussion_r1438338340
##########
utils/install-dependencies.sh:
##########
@@ -83,8 +79,9 @@ function install_dependencies_with_apt() {
fi
sudo apt-get update
- # install OpenResty and some compilation tools
- sudo apt-get install -y git openresty curl openresty-openssl111-dev make
gcc libpcre3 libpcre3-dev libldap2-dev unzip
+ # install some compilation tools
+ sudo apt-get install -y curl make gcc g++ cpanminus libpcre3 libpcre3-dev
libldap2-dev unzip openresty-zlib-dev openresty-pcre-dev
+ # get the APISIX_RUNTIME from .requirements
Review Comment:
this may need be removed
##########
utils/install-dependencies.sh:
##########
@@ -19,6 +19,8 @@
set -ex
+source .requirements
Review Comment:
shoude we consider that the user run the shell in `utils/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
