shreemaan-abhishek commented on code in PR #10729:
URL: https://github.com/apache/apisix/pull/10729#discussion_r1439120969
##########
Makefile:
##########
@@ -40,13 +40,17 @@ ENV_DOCKER ?= docker
ENV_DOCKER_COMPOSE ?= docker-compose --project-directory $(CURDIR) -p
$(project_name) -f $(project_compose_ci)
ENV_NGINX ?= $(ENV_NGINX_EXEC) -p $(CURDIR) -c
$(CURDIR)/conf/nginx.conf
ENV_NGINX_EXEC := $(shell command -v openresty 2>/dev/null || command
-v nginx 2>/dev/null)
-ENV_OPENSSL_PREFIX ?= $(addprefix $(ENV_NGINX_PREFIX), openssl3)
+ENV_OPENSSL_PREFIX ?= /usr/local/openresty/openssl3
Review Comment:
why change this?
##########
Makefile:
##########
@@ -126,12 +128,12 @@ endef
.PHONY: runtime
runtime:
ifeq ($(ENV_NGINX_EXEC), )
-ifeq ("$(wildcard /usr/local/openresty-debug/bin/openresty)", "")
+ifeq ("$(wildcard /usr/local/openresty/bin/openresty)", "")
Review Comment:
ditto
##########
Makefile:
##########
@@ -126,12 +128,12 @@ endef
.PHONY: runtime
runtime:
ifeq ($(ENV_NGINX_EXEC), )
-ifeq ("$(wildcard /usr/local/openresty-debug/bin/openresty)", "")
+ifeq ("$(wildcard /usr/local/openresty/bin/openresty)", "")
@$(call func_echo_warn_status, "WARNING: OpenResty not found. You have
to install OpenResty and add the binary file to PATH before install Apache
APISIX.")
exit 1
else
- $(eval ENV_NGINX_EXEC := /usr/local/openresty-debug/bin/openresty)
- @$(call func_echo_status, "Use openresty-debug as default runtime")
+ $(eval ENV_NGINX_EXEC := /usr/local/openresty/bin/openresty)
Review Comment:
ditto
##########
docs/en/latest/building-apisix.md:
##########
@@ -45,22 +45,22 @@ To build and package APISIX for a specific platform, see
[apisix-build-tools](ht
## Building APISIX from source
-Install dependencies using the script provided by APISIX:
+First of all, we need to specify the version `APISIX_ VERSION` to be installed:
```shell
-curl
https://raw.githubusercontent.com/apache/apisix/master/utils/install-dependencies.sh
-sL | bash -
+APISIX_VERSION='3.7.0'
```
-Save the APISIX version to an environment variable to be used next:
+Then, you can run the following command to clone the APISIX source code from
Github:
```shell
-APISIX_VERSION='3.7.0'
+git clone --depth 1 --branch ${APISIX_VERSION}
https://github.com/apache/apisix.git apisix-${APISIX_VERSION}
```
-Clone the APISIX source code of this version into a new directory
`apisix-APISIX_VERSION`:
+Now, by changing to the directory of the APISIX source code, you can install
the dependencies with the following command:
Review Comment:
I don't see any commands to install dependencies of apisix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
