acuteaura opened a new pull request, #2139:
URL: https://github.com/apache/apisix-ingress-controller/pull/2139

   ### Type of change:
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [ ] Documentation
   - [x] Refactor
   - [ ] Chore
   - [ ] CI/CD or Tests
   
   ### What this PR does / why we need it:
   
   (verbatin commit message)
   
   this commit changes the signal handling in cmd/ingress to be wrapped in a 
context, and inverts which goroutine runs the controller and which watches for 
the context to be cancelled, which allows some scaffolding (`sync.WaitGroup`) 
to be removed and now properly handles the controller exiting with `nil` (as it 
does when leader election fails)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to